Demonstrate telemetry #18
Conversation
Changes include: - Our Couchbase r2 does not require bootstrapping via docker exec so eliminate that. But we do need to add polling of the REST API to make sure we wait for CB to be ready before writing indexes. - Touchbase and Nginx can take advantage of `preStart` - Minor ports cleanup in the compose files - Added Prometheus to compose file but its not used in `start.sh` yet
| removeBucket benchmark | ||
| while true; do | ||
| echo -n '.' | ||
| curl -sf -u ${COUCHBASE_USER}:${COUCHBASE_PASS} \ |
There was a problem hiding this comment.
This section appears in progress, but my question is if you're planning to move the bucket and index creation to the Touchbase preStart script.
There was a problem hiding this comment.
I was trying to make a minimal intervention in this PR so that we're focusing on telemetry. There's a couple things I'd like to clean up, but I didn't want to go too far down the rabbit hole. Up to you though.
There was a problem hiding this comment.
Okay, we both want to change that at some point. Let's see where/how the rest goes.
Nginx's telemetry configuration measures its current connections and makes them available for the Prometheus server. Added a section to our `./start.sh` script to open the Prometheus graph explorer available.
| ], | ||
| "telemetry": { | ||
| "name": "telemetry", | ||
| "url": "/telemetry", |
There was a problem hiding this comment.
Should the URL and name be user-configured options? My reason for asking is how discovery would work in an environment where there may be different for each application.
There was a problem hiding this comment.
Proposal: remove name, url, poll, and ttl as user-configurable options, so that the telemetry stanza is just the following:
"telemetry": {
"port": 9090,
"sensors": [
{...}
]
}This goes with TritonDataCenter/containerpilot#27 (comment) and the discussion that followed.
There was a problem hiding this comment.
Strictly speaking this is a design question about Containerbuddy's telemetry implementation. So I'm moving this conversation to TritonDataCenter/containerpilot#119 (comment) so that anyone following Containerbuddy can follow this discussion.
|
@misterbisson I've added some simple metrics to Touchbase and opened autopilotpattern/couchbase#15 for Couchbase. |
|
🏡 🚶 |
@misterbisson this PR demonstrates the new telemetry feature of Containerbuddy.
I've done a bit of work to update the blueprint to use r2 of our Couchbase blueprint before I add the telemetry work, but I've otherwise tried to avoid doing a rework for things like using CNS to bootstrap the connection to Consul.
Changes so far include:
preStartstart.shyet