-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source to the OperatorRewarded event #3136
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: linning <linningde25@gmail.com>
…ith the production runtime Signed-off-by: linning <linningde25@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I want to double-check the compilation conditions for the Dummy variant.
at_block_number: Number, | ||
}, | ||
XDMProtocolFees, | ||
#[cfg(any(feature = "std", feature = "runtime-benchmarks"))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this dummy is only used in tests and benchmarks, so I’m not sure we want it enabled for all std code?
#[cfg(any(feature = "std", feature = "runtime-benchmarks"))] | |
#[cfg(any(test, feature = "runtime-benchmarks"))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered using test
but interestingly it doesn't compile...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s concerning, because I can only see Dummy
used inside test
and feature = "runtime-benchmarks"
in this PR. So #[cfg(any(test, feature = "runtime-benchmarks"))]
should be enough to make it compile.
What’s the exact compile error?
Is that something you can check, or would you like me to?
This PR adds source to the
OperatorRewarded
event (e.g. which consensus block the bundle fee comes from) along with a minor fix to the consensus test runtime.Code contributor checklist: