-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --create-object-mappings node CLI option #3125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what we want, but maybe the code is too strict on skipping some mappings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense overall, but I'd call it --create-object-mappings
instead of --force-mapping
. And accordingly skip creation altogether if it is false
(the default).
Those who need them would have to specify a CLI option, while everyone else would not have to pay the cost of runtime API calls and save some CPU cycles.
5b9ab57
to
1c12ecc
Compare
This PR adds a
--create-object-mappings
CLI option to the node, which enables mapping generation for new and historic blocks. This option is implied by dev mode.It also fixes the implementation of this feature to:
Code contributor checklist: