Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenient cross-compilation, CUDA in aarch64 container image #3102

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Oct 8, 2024

Major improvements:

  • Cross-compilation no longer requires separate Dockerfiles (which is why they are removed), both native and cross-compilation is supported with a single file
  • Container image is now built as multi-platform, meaning no -aarch64 suffix and no awkwardness related to that
  • Aarch64 farmer container image is now compiled with CUDA support (while regular executable isn't)

Minor improvements:

  • Base image is Ubuntu 22.04 instead of 20.04 (was needed for CUDA packages on aarch64 and we were planning to increase minimum version to 22.04 anyway, will do the same for CLI later)
  • Updated versions of GitHub Actions related to container image building
  • CARGO_NET_GIT_FETCH_WITH_CLI was a workaround for Cargo eating all RAM during aarch64 build under Docker on x86-64 rust-lang/cargo#10583 that with recent-ish improvements and gitoxide usage is no longer necessary

Ignore whitespaces during review, the diff is smaller and clearer that way

Code contributor checklist:

@nazar-pc
Copy link
Member Author

nazar-pc commented Oct 8, 2024

@jim-counter @randywessels @EmilFattakhov FYI to update (simplify) docs

Base automatically changed from rocm to main October 8, 2024 14:53
@nazar-pc nazar-pc dismissed shamil-gadelshin’s stale review October 8, 2024 14:53

The base branch was changed.

@nazar-pc nazar-pc merged commit 589946e into main Oct 8, 2024
9 checks passed
@nazar-pc nazar-pc deleted the cross-compilation branch October 8, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants