-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove gon and use native xcode tools for notarizing #3079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we’re having issues with macOS CI right now, so I’m just going to re-run the tests before it merges.
@teor2345 the issue with macOS ci is fixed already. |
Somewhat as expected, build in CI failed to apply stapling:
https://github.com/autonomys/subspace/actions/runs/11121858572/job/30901889877#step:16:98 If it was as easy as un-commenting it, we'd do that long time ago. Stapling is optional, but would be nice to have. |
Yes it's optional, but since we are not using .app bundles or .dmg files, it will not work with .zip archives.
|
This PR updates the macOS codesigning and notarization workflow for .zip binaries, transitioning from using the gon package to Xcode native tools. It ensures that the .zip file generated for distribution is signed and notarized correctly using Apple’s standard processes.
In order to achieve this, the full xcode application was required to be installed since xcode command-line tools does not have some of the required libraries, and with headless macOS it was not possible to install xcode from the app store. Xcode releases are now available for download through apple developer portal.
Code contributor checklist: