Node client optimization #2865
Merged
Node client optimization #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duplicate code and allow for further optimizations
shamil-gadelshin
previously approved these changes
Jun 19, 2024
nazar-pc
force-pushed
the
node-client-optimization
branch
from
cec9c1e
to
02db0bc
Compare
|
Farmer app info is fallible now, hence minor API change |
shamil-gadelshin
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were numerous issues related to how much we're loading node client connection with subscriptions and requests. This PR attempts to de-duplicate some of the logic under single proxy wrapper and add more caching there, such that very few subscriptions and requests are actually made to node (or controller), optimizing load on node RPC and controller massively.
Code contributor checklist: