Farmer caching tweaks #2579
Merged
Farmer caching tweaks #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to make sure it doesn't use as much memory
nazar-pc
force-pushed
the
farmer-caching-tweaks
branch
from
3f1114f
to
61a1e3d
Compare
shamil-gadelshin
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things I discovered that should be beneficial.
The first commit reduces memory usage on Windows, second simply skips unnecessary caching of pieces that are already in piece cache in the plot cache. Third commit has a special case for Windows to avoid very large farms where piece cache is large enough as is.
Code contributor checklist: