QUIC address translation #2245
Merged
QUIC address translation #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
requested review from
ParthDesai,
vedhavyas,
shamil-gadelshin,
jfrank-summit and
rahulksnv
vedhavyas
reviewed
Nov 19, 2023
| let Some(candidate_protocol) = addr.iter().find_map(|protocol| match protocol { | ||
| udp @ Protocol::Udp(_) => Some(udp), | ||
| tcp @ Protocol::Tcp(_) => Some(tcp), | ||
| _ => None, |
There was a problem hiding this comment.
Shouldn't we capture QuicV1 or Quic here now that its properly translated ?
There was a problem hiding this comment.
Not really, quic is the only UDP protocol we use, so the only thing we care about here are TCP/UDP ports to avoid mismatches. If we were pedantic about it we could check the rest, but dealing with a single protocol rather than a list makes code much shorter.
ParthDesai
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out all of our farmers were clients because address translation was not implemented in libp2p-quic. libp2p/rust-libp2p#4896 fixes that upstream, this PR just pulls it into
susbpace-v7of our fork and uses here sooner.This allows farmers to confirm their external address and become servers. Without that the only server we have are those that specified
--external-addressand they are overloaded.Code contributor checklist: