Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farmer audit benchmark #2124

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Farmer audit benchmark #2124

merged 6 commits into from
Oct 16, 2023

Conversation

nazar-pc
Copy link
Member

This adds auditing benchmark to the farmer, which can be used with existing plot. We will use this going forward to ensure changes we do to the auditing are actually improvements as well as to compare different potential implementations.

The usage is very simple:

subspace-farmer benchmark audit /media/nazar-pc/subspace-farm

The output will look like this:

Benchmarking audit/plot
Benchmarking audit/plot: Warming up for 3.0000 s
Benchmarking audit/plot: Collecting 10 samples in estimated 6.2718 s (220 iterations)
Benchmarking audit/plot: Analyzing
audit/plot              time:   [28.478 ms 28.586 ms 28.697 ms]
                        thrpt:  [ 24216 GiB/s  24310 GiB/s  24402 GiB/s]

It prints both full audit time and throughput that takes plot size into account. In example above auditing speed is ~24TiB/s.

First few commits are just refactoring, the benchmark implementation is one commit at the end.

Resolves #1914

Code contributor checklist:

@nazar-pc nazar-pc force-pushed the farmer-audit-benchmark branch 2 times, most recently from d12f6aa to 7862d93 Compare October 16, 2023 07:40
@nazar-pc
Copy link
Member Author

Windows is so annoying...

Copy link
Member

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny change request. Makes sense otherwise.

jim-counter
jim-counter previously approved these changes Oct 16, 2023
Copy link
Member

@jim-counter jim-counter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nazar-pc nazar-pc added this pull request to the merge queue Oct 16, 2023
@nazar-pc nazar-pc removed this pull request from the merge queue due to a manual request Oct 16, 2023
Copy link
Contributor

@EmilFattakhov EmilFattakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nazar, noted!

@nazar-pc nazar-pc added this pull request to the merge queue Oct 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2023
@nazar-pc nazar-pc added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit 7ea0f61 Oct 16, 2023
10 checks passed
@nazar-pc nazar-pc deleted the farmer-audit-benchmark branch October 16, 2023 19:18
@nazar-pc nazar-pc restored the farmer-audit-benchmark branch October 19, 2023 14:45
@nazar-pc nazar-pc deleted the farmer-audit-benchmark branch October 25, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create auditing benchmark that can be used with existing plots
4 participants