Reduce memory usage during plotting/replotting by deferring memory allocation #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
requested review from
shamil-gadelshin,
rg3l3dr,
vedhavyas and
NingLin-P
as code owners
1 task
ParthDesai
reviewed
Oct 4, 2023
nazar-pc
force-pushed
the
reduce-memory-usage-during-plotting
branch
from
1224ff5
to
019f869
Compare
ParthDesai
reviewed
Oct 4, 2023
ParthDesai
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During plotting there are several things that consume memory: downloaded pieces, deriving of Chiapos tables, final sector construction.
While some of these have to overlap, there is technically no reason for all of them to overlap. In this PR we delay allocation of sector and its metadata to when we actually write there, such that we don't overlap it with piece downloading, reducing peak memory usage as the result. This is especially important because Chiapos derivation uses much more RAM than before due to k20 instead of k17.
Code contributor checklist: