Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Substrate (with core-evm-relay removed) #1549

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Jun 16, 2023

This is the most minimal update possible just to make it compile without warnings and produce blocks. There will be subsequent PR with more dependencies updated.

core-evm-relay is not useful anymore and was very hard to upgrade, so it had to go.

There are some breaking changes and I highly recommend to at least go through the list of mentioned PRs. In our fork I did rebase (which did not require major refactoring).

If you can test some of the domains and other stuff with this PR that'd be awesome.


Some interesting/notable/relevant upstream Substrate PRs:

Snowbridge (eventually core-eth-relay was removed):

Frontier:

Breaking changes:

  • slot duration returned via runtime API is no longer using std::time::Duration (it is caused by Implement TypeInfo for Duration paritytech/scale-info#183 for which I sent a PR, but Duration is serialized into (u64, u32), which is excessive for us and requires extra conversions down the line anyway)
  • serde serialization in sp-domains was not using camelCase naming for fields (idiomatic in JSON), I changed it to do that now
  • core-eth-relay was removed due to seeming uselessness and difficulty of upgrade
  • test_cross_domains_message_should_work test was commented-out due to dependency on core-eth-relay

Code contributor checklist:

@nazar-pc
Copy link
Member Author

Fixed docs

@nazar-pc nazar-pc force-pushed the upgrade-substrate branch 2 times, most recently from fa456c8 to 11f31dc Compare June 16, 2023 12:46
ParthDesai
ParthDesai previously approved these changes Jun 16, 2023
vedhavyas
vedhavyas previously approved these changes Jun 16, 2023
@NingLin-P
Copy link
Member

NingLin-P commented Jun 16, 2023

test_cross_domains_message_should_work test was commented-out due to dependency on core-eth-relay

After this PR is merged, I will add support for testing the core-evm domain and use it in the test instead.

NingLin-P
NingLin-P previously approved these changes Jun 16, 2023
rahulksnv
rahulksnv previously approved these changes Jun 16, 2023
Base automatically changed from remove-forked-substrate-components to main June 16, 2023 16:57
@nazar-pc nazar-pc dismissed stale reviews from rahulksnv, NingLin-P, vedhavyas, and ParthDesai June 16, 2023 16:57

The base branch was changed.

@nazar-pc nazar-pc enabled auto-merge June 16, 2023 17:02
@nazar-pc nazar-pc disabled auto-merge June 16, 2023 19:53
@nazar-pc nazar-pc merged commit 729e03c into main Jun 16, 2023
@nazar-pc nazar-pc deleted the upgrade-substrate branch June 16, 2023 19:53
i1i1 added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Jun 23, 2023
jfrank-summit pushed a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants