-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jupyter notebook plots for parameter importance #296
base: development
Are you sure you want to change the base?
Conversation
Looks good to me from a quick glance. Since it's only jupyter-methods I'd deem it safe to merge, even though travis blocks it... that's some import-struggle with smac methods, I can fix that mid-march. Only thing, I think we should maybe merge to dev-branch first to not mess up general release order? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, didn't check if it works, but can mid-March. If you checked that it works, that's good enough for me though. Otherwise, maybe change the branch to development?
Hi, |
Hi, is there any update on merging this in? |
Hi,
The plots in jupyter notebook were not working for some of the parameter importance analysis. I noticed that the get_jupyter() method in some of these files was referencing a different dictionary structure than the current.
I added/modify this method for each analysis type that was having issues, so that it plots the corresponding images using matplotlib in a grid.
In configurator_footprint.py I changed the import so that it stops throwing the future_warning for sklearn.