Encode nil
values into the document
#190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The encoder was omitting some
nil
values, making themundefined
in the JavaScript library, instead ofnull
.Given the following code:
Results in
completedAt
beingnil
, instead ofScalarValue.Null
. This means the encoder wasn't writing the null value into theDocument
.This PR changes the encoder so it writes
nil
s into theDocument
, with tests to check it.As an implementation detail, now
ScalarValue
conforms toScalarValueRepresentable
.