Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build and test with mxnet 1.7.0 #546

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

sxjscience
Copy link
Contributor

Test for MXNet 1.7.0 nightly to see if there are any issue.

@sxjscience sxjscience changed the title Update build and test with mxnet 1.7.0 nightly [WIP] Update build and test with mxnet 1.7.0 nightly Jun 30, 2020
docs/build.yml Outdated
- jupyter-sphinx>=0.2.2
- mxnet-cu100==1.6.0b20191013
- mxnet-cu100==1.7.0b20200629
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this 1.7.0b actually is a build of the 1.x branch.

@sxjscience
Copy link
Contributor Author

@ciyongch We are going to test AutoGluon with MXNet 1.7. Currently, I'm using the nightly builds of 1.x but will update that to 1.7.rc0 once that's ready.

@ciyongch
Copy link

ciyongch commented Jul 1, 2020

Thanks for tagging me on this @sxjscience , I'm not sure whether there'll be nightly image for v1.7.x or later v1.7.rc0. Anyway, I will keep you posted when 1.7.rc0 is announced.

@ciyongch
Copy link

ciyongch commented Jul 9, 2020

Hi @sxjscience , MXNet 1.7.0.rc0 is cut off, would you mind to have a try with the latest code base? Thanks.

@sxjscience
Copy link
Contributor Author

@ciyongch Would you know how should I try it in CI?

@ciyongch
Copy link

ciyongch commented Jul 9, 2020

push an [empty] commit?

@sxjscience
Copy link
Contributor Author

sxjscience commented Jul 9, 2020 via email

@ciyongch
Copy link

ciyongch commented Jul 9, 2020

Sorry for misunderstood your requirement. Probably there's no 1.7.0.rc0 (or 1.7.x branch) pip wheel yet, ping @szha @leezu to double confirm.

@sxjscience
Copy link
Contributor Author

@ciyongch Basically the CI fails by throwing weakref not pickleble error. It might be due to the fact the gluon block is not pickleble. But I need to investigate the root cause.

@szha
Copy link

szha commented Jul 13, 2020

Job PR-546-8 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-546/8/index.html

@sxjscience
Copy link
Contributor Author

@ciyongch The CI of AutoGluon has passed after the PR in MXNet is reverted

@sxjscience sxjscience changed the title [WIP] Update build and test with mxnet 1.7.0 nightly Update build and test with mxnet 1.7.0 Jul 13, 2020
@sxjscience
Copy link
Contributor Author

@Innixma
Copy link
Contributor

Innixma commented Jul 13, 2020

Great! Is it ok if we wait until 1.7.0 is officially released before merging this PR?

@sxjscience
Copy link
Contributor Author

@Innixma Yes, it's fine to wait until the official 1.7.0 so I will leave it open for now.

@zhreshold
Copy link
Contributor

@sxjscience Good job, thanks for pushing this

@ciyongch
Copy link

ciyongch commented Jul 14, 2020

It's great to root cause the issue, thanks @sxjscience !
Just notice apache/mxnet#18358 was already reverted. Thanks.

@szha
Copy link

szha commented Aug 8, 2020

Job PR-546-10 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-546/10/index.html

update

update

use the new wheel

add new pip wheel for rc0

update

update installation guide + use prebuilt MXNet 1.7
@szha
Copy link

szha commented Aug 14, 2020

Job PR-546-11 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-546/11/index.html

@szha
Copy link

szha commented Aug 14, 2020

Job PR-546-12 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-546/12/index.html

docs/build.yml Show resolved Hide resolved
docs/install-include.rst Show resolved Hide resolved
@szha
Copy link

szha commented Aug 14, 2020

Job PR-546-13 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-546/13/index.html

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on this fix!

@sxjscience sxjscience merged commit c98d737 into autogluon:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants