Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Gemini tool calling (plus general fixes and updates) #67

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

marklysze
Copy link
Collaborator

@marklysze marklysze commented Oct 18, 2024

Why are these changes needed?

The Gemini class doesn't currently support tool calling.

This PR adds tool calling.

Additional updates:

  • Removal of role alternation, this no longer appears necessary
  • Image input corrected for non-Vertex AI
  • Costs updated

NOTE: This hasn't been tested with Vertex AI authentication, if someone can test it that would be good. Please try the client test files in my repo.

No documentation added, yet. TODO

Related issue number

Noted in Discord issue

Checks

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 206 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
autogen/oai/gemini.py 0.00% 206 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
unittests 31.22% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
setup.py 0.00% <ø> (ø)
autogen/oai/gemini.py 0.00% <0.00%> (ø)

@sonichi sonichi requested review from ryannli and BabyCNM October 19, 2024 02:26
@marklysze
Copy link
Collaborator Author

Hey @yiranwu0, would you be able to assist in identifying why the ContribGraphRagTests test is failing?

@yiranwu0
Copy link
Collaborator

I am not familiar with this PR, mayber @randombet can help?

@marklysze
Copy link
Collaborator Author

I am not familiar with this PR, mayber @randombet can help?

I've found out that for graphrag_sdk they've changed some terminology since moving to V2, Schema is now called Ontology. I've updated the test.

@qingyun-wu qingyun-wu self-requested a review October 22, 2024 04:14
@sonichi sonichi requested a review from randombet October 24, 2024 20:34
Copy link
Collaborator

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one small issue in the workflow. Otherwise lgtm.

.github/workflows/contrib-graph-rag-tests.yml Outdated Show resolved Hide resolved
Co-authored-by: Chi Wang <4250911+sonichi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alt-models Non-OpenAI Models / Client Classes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants