-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Gemini tool calling (plus general fixes and updates) #67
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hey @yiranwu0, would you be able to assist in identifying why the ContribGraphRagTests test is failing? |
I am not familiar with this PR, mayber @randombet can help? |
I've found out that for graphrag_sdk they've changed some terminology since moving to V2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one small issue in the workflow. Otherwise lgtm.
Co-authored-by: Chi Wang <4250911+sonichi@users.noreply.github.com>
Why are these changes needed?
The Gemini class doesn't currently support tool calling.
This PR adds tool calling.
Additional updates:
NOTE: This hasn't been tested with Vertex AI authentication, if someone can test it that would be good. Please try the client test files in my repo.
No documentation added, yet. TODO
Related issue number
Noted in Discord issue
Checks