Fix: added agent name to client.create calls to prevent runtime loggi… #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The multimodal part looks good to me, but I am not sure about the client side. If we can pass the test cases, I think it should be good. |
BabyCNM
approved these changes
Oct 2, 2024
|
Okay, have tested both and they are working. Thanks @LaraNonino! I can pytest the |
marklysze
approved these changes
Oct 2, 2024
|
@LaraNonino thanks for your contribution. Are you on Discord? I'd like to follow up and acknowledge your contribution there. |
|
Thank you for taking time to review it and merging. I reached out on discord. |
odoochain
pushed a commit
to odoochain/autogen
that referenced
this pull request
Nov 10, 2024
* replace Event to CloudEvent WIP * switch to CloudEvents * dapr implementation WIP * fix namespaces and dapr sdk weirdness * WIP * dapr support WIP * dapr WIP * dapr WIP * dapr semi-working implementation * fix mapping bug * dapr reminders in sandbox * fix prompts * merge almost done * switch to Newtnsoft serialization for Marketing * add event surogate for Orleans serialization * remove newtnsoft serialization (not needed) * cleanup appsettings in marketing sample
odoochain
pushed a commit
to odoochain/autogen
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: added agent name to client.create calls to prevent runtime logging error (microsoft#3507)
client.createcall inmultimodal_conversable_agent.pyby addingagent=self.nameas a parameter.client.createcall insociety_of_mind_agent.pywithagent=self.name.These changes ensure that the agent's name is passed correctly, preventing the
NoneTypeerror during runtime logging inMultimodalConversableAgent.