Skip to content

Commit

Permalink
[hgi] Undo portion of change 2351166. Maya test
Browse files Browse the repository at this point in the history
testUsdReferenceAssemblySelection crashes due to the nullptr hgi instance. The
test is likely creating an unsupported HgiGL instance due to a lack of proper
GL context, which needs further investigation to fix. A ticket will be filed
for this issue.

(Internal change: 2352432)
  • Loading branch information
clach authored and pixar-oss committed Dec 21, 2024
1 parent 0c3326f commit c281ea3
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions pxr/imaging/hgi/hgi.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,12 @@ _MakeNewPlatformDefaultHgi()
if (!instance->IsBackendSupported()) {
TF_DEBUG(HGI_DEBUG_INSTANCE_CREATION).Msg("Hgi %s is not supported\n",
hgiType);
delete instance;
return nullptr;
// XXX Currently, returning nullptr (rather than a non-supported hgi
// instance) causes a crash in one of our studio tests. We disable the
// desired behavior until we can fix the test.
return instance;
// delete instance;
// return nullptr;
}

TF_DEBUG(HGI_DEBUG_INSTANCE_CREATION).Msg("Successfully created platform "
Expand Down

0 comments on commit c281ea3

Please sign in to comment.