Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support credential JSON for Spanner #1942

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

lexcao
Copy link
Contributor

@lexcao lexcao commented Jun 15, 2024

Closes #1941

@lexcao lexcao requested a review from a team June 15, 2024 18:05
@github-actions github-actions bot added the area/datastore Affects the storage system label Jun 15, 2024
Closes authzed#1941

Signed-off-by: Lex Cao <lexcao@foxmail.com>
Copy link

github-actions bot commented Jun 15, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lexcao lexcao force-pushed the feat/spanner-credential-json branch from 9c1c7a3 to 59c478a Compare June 15, 2024 18:06
@lexcao
Copy link
Contributor Author

lexcao commented Jun 15, 2024

I have read the CLA Document and I hereby sign the CLA

@lexcao
Copy link
Contributor Author

lexcao commented Jun 15, 2024

recheck

authzedbot added a commit to authzed/cla that referenced this pull request Jun 15, 2024
@josephschorr
Copy link
Member

@lexcao I'm curious: how is this different from credentialsFile?

@lexcao
Copy link
Contributor Author

lexcao commented Jun 16, 2024

Hi @josephschorr
The credentialsFile would read the credential JSON from file system.
The credentialsJSON is the JSON content for no matter where it comes from.

In my use case, I use SpiceDB library and my Spanner credential is fetched from remote server like config center.

Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr josephschorr added this pull request to the merge queue Jun 16, 2024
Merged via the queue into authzed:main with commit b3acf2f Jun 16, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
@lexcao lexcao deleted the feat/spanner-credential-json branch June 17, 2024 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/datastore Affects the storage system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow credential JSON for Spanner options
2 participants