Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for static linking on iOS #555

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Add support for static linking on iOS #555

merged 1 commit into from
Nov 15, 2022

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 15, 2022 •
edited
Loading

Changes

This PR adds support for using the library with use_frameworks! :linkage => :static on iOS.

References

Fixes #528

Testing

The changes were tested manually with React Native 0.70.3, Xcode 14.1 (14B47b), using an iPhone 14 simulator running iOS 16.1.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket marked this pull request as ready for review November 15, 2022 03:30
@Widcket Widcket requested a review from a team as a code owner November 15, 2022 03:30
@Widcket Widcket mentioned this pull request Nov 15, 2022
Closed
@Widcket Widcket merged commit 1b5fb53 into master Nov 15, 2022
@Widcket Widcket deleted the feature/static-linking-support branch November 15, 2022 11:34
@poovamraj poovamraj mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poovamraj poovamraj poovamraj approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.14.0] iOS build error
2 participants
@Widcket @poovamraj