Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies in the lock file #313

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Bump dependencies in the lock file #313

merged 2 commits into from
Jun 5, 2020

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented Jun 5, 2020

Changes

  • Bumps the dependency versions respecting the package.json file contents.
  • Changes the CI script Node version from 8 to LTS

@lbalmaceda lbalmaceda requested a review from a team June 5, 2020 15:57
@lbalmaceda lbalmaceda added tiny This PR may require very low effort to action, or contains few changes to review dependencies One or more dependencies are being bumped labels Jun 5, 2020
@lbalmaceda lbalmaceda added this to the v2-Next milestone Jun 5, 2020
davidpatrick
davidpatrick previously approved these changes Jun 5, 2020
@lbalmaceda
Copy link
Contributor Author

Getting the following error on the CI

error mkdirp@1.0.4: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.17.0"
error Found incompatible module.

I've traced the mkdirp > 1.0.0 requirement to:

jsdoc-to-markdown -> dmd -> cache-point ->mkdirp

which we require here as dev dependency. https://github.com/auth0/react-native-auth0/blob/master/package.json#L40

I'll update the package.json file to specify the min engine required, and if required, the CI script to run tests with Node 10

@lbalmaceda lbalmaceda merged commit 06909eb into master Jun 5, 2020
@lbalmaceda lbalmaceda deleted the fix-vuln branch June 5, 2020 16:50
@lbalmaceda lbalmaceda modified the milestones: v2-Next, v2.4.0 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Security dependencies One or more dependencies are being bumped tiny This PR may require very low effort to action, or contains few changes to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants