Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling by using authentication error class #228

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Fix error handling by using authentication error class #228

merged 1 commit into from
Jul 15, 2019

Conversation

lbalmaceda
Copy link
Contributor

Changes

The error handling for the WebAuth controller was wrong. Should be using the AuthError instead of a generic Auth0Error class.

References

#220

Testing

Manual testing only.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added the tiny This PR may require very low effort to action, or contains few changes to review label Jul 15, 2019
@lbalmaceda lbalmaceda added this to the v1-Next milestone Jul 15, 2019
@lbalmaceda lbalmaceda requested a review from a team July 15, 2019 15:29
@lbalmaceda lbalmaceda merged commit fed7758 into master Jul 15, 2019
@lbalmaceda lbalmaceda modified the milestones: v1-Next, v1.5.0 Jul 15, 2019
@lbalmaceda lbalmaceda deleted the err-handling branch July 15, 2019 17:04
@lbalmaceda lbalmaceda mentioned this pull request Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisrudge luisrudge luisrudge approved these changes

Assignees
No one assigned
Labels
CH: Fixed tiny This PR may require very low effort to action, or contains few changes to review
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lbalmaceda @luisrudge