-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed broken podspec for Cocoapods installations #136
Conversation
Can we merge this 😋? |
@cocojoe can you review this one please? |
I don't believe it was intended to be used as a pod, it's not something listed in the installation. It's never been published, just looks like a place holder podfile. What are you doing with it? |
@cocojoe What is the reason of having a .podspec if there is no intention to use it with Cocoapods 😜? Most RN libraries support Cocoapods nowadays (even through Btw, npm and pods go perfectly together. This is how I'm using the Auth0 library with the proposed changes in this PR: |
If this is just used internally then maybe yes, no harm. |
@cocojoe you don't have to publish for it to work on Cocoapods. Cocoapods is the industry standard in iOS development, and most people who are working on serious, large projects are going to be using Cocoapods. It's a pretty serious limitation not to support it. At the very least, you can support it unofficially by just merging this PR. There already is a podspec that is completely broken, why not fix it? |
Furthermore, I couldn't even get this library to work without having to fork this repo. If you're running an iOS setup with React Native installed via Cocoapods, the search headers will be completely wrong and this project won't be able to find and use the React framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not published, expands usage. LGTM
@cocojoe thanks a bunch! |
The current podspec is invalid and will cause errors in
pod install
. This update fixes these issues and adds better version control that is tied to the npm version.