Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make options optional in handlers #78

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Make options optional in handlers #78

merged 1 commit into from
Mar 31, 2020

Conversation

balazsorban44
Copy link
Contributor

@balazsorban44 balazsorban44 commented Feb 4, 2020 •
edited
Loading

Description

In the file instance.d.ts, the handlers third arguments were marked as required, even though they are optional.

Testing

–

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@balazsorban44
Copy link
Contributor Author

ping @sandrinodimattia 🙂

@sandrinodimattia sandrinodimattia merged commit fc27dab into auth0:master Mar 31, 2020
@balazsorban44 balazsorban44 deleted the handler-options-optional branch March 31, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandrinodimattia sandrinodimattia Awaiting requested review from sandrinodimattia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balazsorban44 @sandrinodimattia