Clarify sso option behavior in the README
#946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisrudge
changed the title
sso option behavior in the README
luisrudge
approved these changes
Mar 24, 2017
luisrudge
added a commit
that referenced
this pull request
Mar 24, 2017
This reverts commit 043e535.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in this support ticket the sso switch does not actually influence the creation of a SSO session on the Auth0 side. This is imho not properly reflected in the docs for this switch, so I updated it.
I'm still not sure if the
ssoswitch in the current state couldn't be unified withrememberLastLoginbecause, according to the ticket, both are only frontend features and the SSO data is probably not used for other cases.