-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix header height calculation for large titles #1859
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
168 changes: 168 additions & 0 deletions
168
src/__tests__/ui/box/__snapshots__/header.test.jsx.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`Header renders correctly with basic props 1`] = ` | ||
| <div | ||
| className="auth0-lock-header" | ||
| > | ||
| <div | ||
| className="auth0-lock-header-bg auth0-lock-blur-support" | ||
| > | ||
| <div | ||
| className="auth0-lock-header-bg-blur auth0-lock-no-grayscale" | ||
| style={ | ||
| Object { | ||
| "backgroundImage": "url('some-image.png')", | ||
| } | ||
| } | ||
| /> | ||
| <div | ||
| className="auth0-lock-header-bg-solid" | ||
| style={ | ||
| Object { | ||
| "backgroundColor": "red", | ||
| } | ||
| } | ||
| /> | ||
| </div> | ||
| <div | ||
| className="auth0-lock-header-welcome" | ||
| > | ||
| <div | ||
| className="auth0-lock-firstname" | ||
| title="Header" | ||
| > | ||
| Header | ||
| </div> | ||
| </div> | ||
| </div> | ||
| `; | ||
|
|
||
| exports[`Header sets the header size property on the document element 1`] = ` | ||
| <div | ||
| className="auth0-lock-header" | ||
| > | ||
| <div | ||
| className="auth0-lock-header-bg auth0-lock-blur-support" | ||
| > | ||
| <div | ||
| className="auth0-lock-header-bg-blur auth0-lock-no-grayscale" | ||
| style={ | ||
| Object { | ||
| "backgroundImage": "url('some-image.png')", | ||
| } | ||
| } | ||
| /> | ||
| <div | ||
| className="auth0-lock-header-bg-solid" | ||
| style={ | ||
| Object { | ||
| "backgroundColor": "red", | ||
| } | ||
| } | ||
| /> | ||
| </div> | ||
| <div | ||
| className="auth0-lock-header-welcome" | ||
| > | ||
| <div | ||
| className="auth0-lock-firstname" | ||
| title="Header" | ||
| > | ||
| Header | ||
| </div> | ||
| </div> | ||
| </div> | ||
| `; | ||
|
|
||
| exports[`Header shows the back button when there is a handler 1`] = ` | ||
| <div | ||
| className="auth0-lock-header" | ||
| > | ||
| <span | ||
| aria-label="back" | ||
| className="auth0-lock-back-button" | ||
| dangerouslySetInnerHTML={ | ||
| Object { | ||
| "__html": "<svg aria-hidden=\\"true\\" focusable=\\"false\\" enable-background=\\"new 0 0 24 24\\" version=\\"1.0\\" viewBox=\\"0 0 24 24\\" xml:space=\\"preserve\\" xmlns=\\"http://www.w3.org/2000/svg\\" xmlns:xlink=\\"http://www.w3.org/1999/xlink\\"> <polyline fill=\\"none\\" points=\\"12.5,21 3.5,12 12.5,3 \\" stroke=\\"#000000\\" stroke-miterlimit=\\"10\\" stroke-width=\\"2\\"></polyline> <line fill=\\"none\\" stroke=\\"#000000\\" stroke-miterlimit=\\"10\\" stroke-width=\\"2\\" x1=\\"22\\" x2=\\"3.5\\" y1=\\"12\\" y2=\\"12\\"></line> </svg>", | ||
| } | ||
| } | ||
| id="undefined-back-button" | ||
| onClick={[Function]} | ||
| onKeyPress={[Function]} | ||
| role="button" | ||
| tabIndex={0} | ||
| /> | ||
| <div | ||
| className="auth0-lock-header-bg auth0-lock-blur-support" | ||
| > | ||
| <div | ||
| className="auth0-lock-header-bg-blur auth0-lock-no-grayscale" | ||
| style={ | ||
| Object { | ||
| "backgroundImage": "url('some-image.png')", | ||
| } | ||
| } | ||
| /> | ||
| <div | ||
| className="auth0-lock-header-bg-solid" | ||
| style={ | ||
| Object { | ||
| "backgroundColor": "red", | ||
| } | ||
| } | ||
| /> | ||
| </div> | ||
| <div | ||
| className="auth0-lock-header-welcome" | ||
| > | ||
| <div | ||
| className="auth0-lock-firstname" | ||
| title="Header" | ||
| > | ||
| Header | ||
| </div> | ||
| </div> | ||
| </div> | ||
| `; | ||
|
|
||
| exports[`Header shows the logoUrl when there is no name 1`] = ` | ||
| <div | ||
| className="auth0-lock-header" | ||
| > | ||
| <div | ||
| className="auth0-lock-header-bg auth0-lock-blur-support" | ||
| > | ||
| <div | ||
| className="auth0-lock-header-bg-blur" | ||
| style={ | ||
| Object { | ||
| "backgroundImage": "url('some-image.png')", | ||
| } | ||
| } | ||
| /> | ||
| <div | ||
| className="auth0-lock-header-bg-solid" | ||
| style={ | ||
| Object { | ||
| "backgroundColor": "red", | ||
| } | ||
| } | ||
| /> | ||
| </div> | ||
| <div | ||
| className="auth0-lock-header-welcome" | ||
| > | ||
| <img | ||
| alt="" | ||
| className="auth0-lock-header-logo" | ||
| src="some-logo.png" | ||
| /> | ||
| <div | ||
| className="auth0-lock-name" | ||
| title="This is the header" | ||
| > | ||
| This is the header | ||
| </div> | ||
| </div> | ||
| </div> | ||
| `; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| import React from 'react'; | ||
| import { expectComponent } from 'testUtils'; | ||
|
|
||
| const getComponent = () => require('ui/box/header').default; | ||
|
|
||
| describe('Header', () => { | ||
| let Header; | ||
|
|
||
| beforeEach(() => { | ||
| Header = getComponent(); | ||
| }); | ||
|
|
||
| it('renders correctly with basic props', () => { | ||
| const props = { | ||
| title: 'This is the header', | ||
| name: 'Header', | ||
| logoUrl: 'some-logo.png', | ||
| backgroundUrl: 'some-image.png', | ||
| backgroundColor: 'red' | ||
| }; | ||
|
|
||
| expectComponent(<Header {...props} />).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| it('shows the back button when there is a handler', () => { | ||
| const props = { | ||
| title: 'This is the header', | ||
| name: 'Header', | ||
| logoUrl: 'some-logo.png', | ||
| backgroundUrl: 'some-image.png', | ||
| backgroundColor: 'red', | ||
| backHandler: () => jest.fn() | ||
| }; | ||
|
|
||
| expectComponent(<Header {...props} />).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| it('shows the logoUrl when there is no name', () => { | ||
| const props = { | ||
| title: 'This is the header', | ||
| backgroundUrl: 'some-image.png', | ||
| logoUrl: 'some-logo.png', | ||
| backgroundColor: 'red' | ||
| }; | ||
|
|
||
| expectComponent(<Header {...props} />).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| it('sets the header size property on the document element', () => { | ||
| const spy = jest.spyOn(document.documentElement.style, 'setProperty'); | ||
|
|
||
| const props = { | ||
| title: 'This is the header', | ||
| name: 'Header', | ||
| logoUrl: 'some-logo.png', | ||
| backgroundUrl: 'some-image.png', | ||
| backgroundColor: 'red' | ||
| }; | ||
|
|
||
| expectComponent(<Header {...props} />, { | ||
| createNodeMock: () => ({ clientHeight: 100 }) | ||
| }).toMatchSnapshot(); | ||
|
|
||
| expect(spy).toHaveBeenCalledWith('--header-height', '100px'); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just formatting, nothing changed here.