Emit authorization_error event on passwordless error #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
previously approved these changes
Jan 20, 2020
| describe('on webApi.passwordlessVerify() callback', () => { | ||
| it('formats error when there is an error ', () => { | ||
| actions.logIn('id'); | ||
| describe('when there is an eror', () => { |
There was a problem hiding this comment.
Typo. If you decide to change it, you'll need to regenerate the snapshots
Suggested change
| describe('when there is an eror', () => { | |
| describe('when there is an error', () => { |
There was a problem hiding this comment.
I've fixed the typo locally instead of merging the suggestion.
The event is already documented, it just wasn't being emitted in one of the places it should have been.
lbalmaceda
approved these changes
Jan 20, 2020
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Mar 5, 2020
* Emit authorization_error event on passwordless error * Removed unneccessary import * Fixed typo in test name, regenerated snapshots * Regenerated lockfile
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
* Emit authorization_error event on passwordless error * Removed unneccessary import * Fixed typo in test name, regenerated snapshots * Regenerated lockfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, the
authorization_errorevent is now emitted when an error occurs while submitting a code in the passwordless flow.References
Originated from an internal service desk ticket.1
Testing
Checklist