Adding terms for passwordless #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on when this might land? I'm considering switching to passwordless, but would need to require new users accept our Terms of Service during signup. |
|
@sholladay Hi! I still need to add the tests for this. Hopefully I can get some time on this issue this week or the next. |
This was referenced Oct 30, 2018
|
@luisrudge Have you been able to look into that? Thank you! |
luisrudge
changed the title
joshcanhelp
suggested changes
Jan 14, 2019
| @@ -12,7 +12,8 @@ import { | |||
| send, | |||
| setPasswordlessStarted, | |||
| setResendFailed, | |||
| setResendSuccess | |||
| setResendSuccess, | |||
| toggleTermsAcceptance as switchTermsAcceptance | |||
There was a problem hiding this comment.
Would switchTermsAcceptance be better named as toggleTermsAcceptanceParent or similar? It looks like you're overriding that method here but the name suggests it does something different ... and even then, if it did, the name is pretty similar.
There was a problem hiding this comment.
renamed to internalToggleTermsAcceptance
src/__tests__/connection/passwordless/__snapshots__/passwordless.test.js.snap
Show resolved
Hide resolved
src/__tests__/connection/passwordless/__snapshots__/passwordless.test.js.snap
Show resolved
Hide resolved
src/__tests__/connection/passwordless/__snapshots__/passwordless.test.js.snap
Show resolved
Hide resolved
src/__tests__/connection/passwordless/__snapshots__/passwordless.test.js.snap
Show resolved
Hide resolved
joshcanhelp
approved these changes
Jan 14, 2019
|
released in v11.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1421