Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support verification of Long[] datatype like in JWTCreator #278

Merged
merged 3 commits into from
Feb 14, 2020
Merged

Support verification of Long[] datatype like in JWTCreator #278

merged 3 commits into from
Feb 14, 2020

Conversation

skjolber
Copy link
Contributor

Add Long array type so that the Verification claim types are the same as supported in JWTCreator.

@skjolber skjolber mentioned this pull request Nov 16, 2018
Merged
@stale
Copy link

stale bot commented Oct 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Oct 26, 2019
@skjolber
Copy link
Contributor Author

Ping.

@stale stale bot removed the closed:stale Issue or PR has not seen activity recently label Oct 26, 2019
@jimmyjames jimmyjames self-requested a review January 17, 2020 17:46
@lbalmaceda
Copy link
Contributor

@skjolber please rebase+fix conflicts so I can leave a review

@skjolber skjolber requested a review from a team February 14, 2020 08:51
lbalmaceda
lbalmaceda suggested changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor javadoc problem.

@lbalmaceda lbalmaceda removed the request for review from jimmyjames February 14, 2020 17:45
@lbalmaceda
Copy link
Contributor

Thanks for this @skjolber

@lbalmaceda lbalmaceda added this to the v3-Next milestone Feb 14, 2020
@lbalmaceda lbalmaceda merged commit 5fa3fe3 into auth0:master Feb 14, 2020
@lbalmaceda lbalmaceda modified the milestones: v3-Next, 3.10.0 Feb 14, 2020
@skjolber skjolber deleted the verifyLongArray branch February 14, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@skjolber @lbalmaceda