Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-5703] [GH-283] Add support for exclusion URLs in JWT middleware #319

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

developerkunal
Copy link
Contributor

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

🔧 Changes

  • Added exclusionUrlHandler property to the JWTMiddleware struct.
  • Introduced a new option WithExclusionUrls, which accepts a slice of strings.
  • Updated the code to handle exclusion URLs appropriately.

📚 References

🔬 Testing

  • Test cases have been added to cover the new functionality, specifically the exclusionUrlHandler property and the WithExclusionUrls option.
  • Ensure that exclusion URLs are handled correctly by the middleware.
  • Manual testing should verify the proper exclusion of URLs as per the updated logic.

@developerkunal developerkunal requested a review from a team as a code owner February 18, 2025 11:57
@developerkunal developerkunal linked an issue Feb 18, 2025 that may be closed by this pull request
1 task
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (410ba07) to head (a26050b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   96.25%   96.39%   +0.14%     
==========================================
  Files           8        8              
  Lines         347      361      +14     
==========================================
+ Hits          334      348      +14     
  Misses         10       10              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@developerkunal developerkunal merged commit f0aafb9 into master Feb 20, 2025
10 checks passed
@developerkunal developerkunal deleted the add-support-for-exclusion-urls-jwt-auth branch February 20, 2025 06:43
@developerkunal developerkunal mentioned this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support addition of exclusion URLs to the JWT auth
3 participants