Use webAuth.login when calling signupAndLogin to support Univeral Login Page #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
Feb 14, 2018
src/web-auth/redirect.js
Outdated
| @@ -2,6 +2,7 @@ var CrossOriginAuthentication = require('./cross-origin-authentication'); | |||
| var Warn = require('../helper/warn'); | |||
|
|
|||
| function Redirect(auth0, options) { | |||
| this.webAuth = auth0; | |||
| this.baseOptions = options; | |||
| this.client = auth0.client; | |||
There was a problem hiding this comment.
could this line be removed now, since this.webAuth.client is the same as this.client?
There was a problem hiding this comment.
absolutely. I removed in the next commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IN order to make
webauth.client.signupAndLoginsupport the HLP, we need to make it sure that we call thewebauth.loginafter the signup, since this method will pick the right endpoint to login