Fix federated param #661
Merged
Fix federated param #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaguiarz
approved these changes
Feb 12, 2018
joshcanhelp
reviewed
Feb 12, 2018
| qString = qs.stringify(objectHelper.blacklist(params, ['federated'])); | ||
| if ( | ||
| options && | ||
| (options.federated !== undefined && |
There was a problem hiding this comment.
@luisrudge - Parens not needed here.
Logic is confusing here but I understand why. Just breaking it down ...
- No
options=== nofederatedoption so that makes sense - For the last one, wouldn't
options.federated === 'true'be a little more explicit here? - For the 2nd and 3rd, you're checking for
undefinedandfalsein the case wherefederatedis in the URL but not set. Wouldn't it just be one or the other or are there browser differences being accounted for? I'm wondering if it's not better to sayObject.keys(options).indexOf('federated') > -1, then decide the values that should be true (probably 'true' and undefined)
There was a problem hiding this comment.
The issue with using object.keys is that, in our docs, we recommended doing: federated: ''. But there's all sorts of usage, including federated: 'true', federated: true, federated: 'false' (which would be true if I used object.keys only). So, I'm doing a "catch all false possibilities" in this if check just in case.
aaguiarz
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
federatedparam is a special param because you don't send the value with it. So, the url should be/logout?federatedand notlogout?federated=true|false. Because we suggest in the docs that we might accept a string in this case, I had to keep it compatible with previous versions, that's why we have some special if conditions.