Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for correct options. #289

Closed
wants to merge 1 commit into from
Closed

Check for correct options. #289

wants to merge 1 commit into from

Conversation

yageek
Copy link

@yageek yageek commented Jan 5, 2017

The responseType is token and not id_token. Trying to fix #288

The responseType is `token` and not `id_token`.
@hzalaz
Copy link
Member

hzalaz commented Jan 5, 2017

@yageek thanks for the PR but the check for nonce is only for id_token. We are fixing it by only validating that for OAuth redirect via /authorize

@hzalaz hzalaz closed this Jan 5, 2017
@yageek
Copy link
Author

yageek commented Jan 5, 2017

Ok. But why does the transaction manager not attach a nonce if I did not specify one in the options before calling loginWithCredentials?

@hzalaz
Copy link
Member

hzalaz commented Jan 5, 2017

because there is a bug we need to fix to avoid generating nonce for that endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nonce does not match
2 participants