Return policy attr in errors + responseType validation #273

glena · 2016-12-16T19:58:45Z

Closes #271

hzalaz · 2016-12-16T20:00:11Z

src/web-auth/redirect.js

@@ -36,6 +37,10 @@ Redirect.prototype.login = function (options, cb) {

  this.warn.warning('`webauth.redirect.login` will be soon deprecated, use `webauth.login` instead.');

+  assert.check(params, { type: 'object', message: 'options parameter is not valid' }, {


Can we test this?

hzalaz · 2016-12-16T20:00:15Z

src/web-auth/index.js

@@ -259,6 +259,10 @@ WebAuth.prototype.login = function (options) {
    'audience'
  ]).with(options);

+  assert.check(params, { type: 'object', message: 'options parameter is not valid' }, {


Can we test this?

codecov-io · 2016-12-16T20:03:41Z

Current coverage is 100% (diff: 100%)

Merging #273 into v8 will not change coverage

@@            v8   #273   diff @@
=================================
  Files       30     30          
  Lines      931    936     +5   
  Methods    164    164          
  Messages     0      0          
  Branches   133    134     +1   
=================================
+ Hits       931    936     +5   
  Misses       0      0          
  Partials     0      0

Powered by Codecov. Last update 94ac7fc...2fb0022

hzalaz reviewed Dec 16, 2016

View reviewed changes

hzalaz approved these changes Dec 16, 2016

View reviewed changes

hzalaz added the CH: Fixed label Dec 16, 2016

hzalaz added this to the v8-Next milestone Dec 16, 2016

glena added 4 commits December 16, 2016 17:22

expose policy attr in error responses

96f85be

[v8] SignupAndLogin blows up if no response type is set #271

513c1bb

fix + test

088b7be

fix non optional params + added tests

2fb0022

glena force-pushed the fixes branch from ab5392e to 2fb0022 Compare December 16, 2016 20:22

hzalaz merged commit 61512f9 into v8 Dec 16, 2016

hzalaz deleted the fixes branch December 16, 2016 20:28

hzalaz modified the milestones: v8-Next, v8.0.0-beta.2 Dec 16, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return policy attr in errors + responseType validation #273

Return policy attr in errors + responseType validation #273

glena commented Dec 16, 2016

hzalaz Dec 16, 2016

hzalaz Dec 16, 2016

codecov-io commented Dec 16, 2016 •

edited

Loading

		@@ -36,6 +37,10 @@ Redirect.prototype.login = function (options, cb) {

		this.warn.warning('`webauth.redirect.login` will be soon deprecated, use `webauth.login` instead.');

		assert.check(params, { type: 'object', message: 'options parameter is not valid' }, {

Return policy attr in errors + responseType validation #273

Return policy attr in errors + responseType validation #273

Conversation

glena commented Dec 16, 2016

hzalaz Dec 16, 2016

Choose a reason for hiding this comment

hzalaz Dec 16, 2016

Choose a reason for hiding this comment

codecov-io commented Dec 16, 2016 • edited Loading

Current coverage is 100% (diff: 100%)

codecov-io commented Dec 16, 2016 •

edited

Loading