Downgrade browserstack-cypress-cli to fix test failures #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
previously approved these changes
Nov 19, 2021
stevehobbsdev
changed the title
added 3 commits
November 25, 2021 11:00
Upgrading to >= 6.1 breaks it as it no longer finds the module file. Has been discussed here: yowainwright/es-check#139
stevehobbsdev
force-pushed
the
fix/browserstack
branch
from
cdb8963 to
1854679
Compare
stevehobbsdev
commented
Nov 25, 2021
| @@ -21,7 +21,7 @@ | |||
| "test:watch:integration": "concurrently --raw npm:dev 'npm:test:open:integration'", | |||
| "test:es-check": "npm run test:es-check:es5 && npm run test:es-check:es2015:module", | |||
| "test:es-check:es5": "es-check es5 'dist/auth0-spa-js.production.js'", | |||
| "test:es-check:es2015:module": "es-check es2015 --module 'dist/auth0-spa-js.production.esm.js'", | |||
| "test:es-check:es2015:module": "es-check es2015 'dist/auth0-spa-js.production.esm.js' --module ", | |||
There was a problem hiding this comment.
There was a bug upgrading es-check to >= 6.1, and this change fixes it. Reported here
frederikprijck
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it turns out that the Browserstack tests were failing on Browserstack but being reported as passing to Circle. The tests were failing thanks to an upgraded version of
browserstack-cypress-clithat caused the CLI to exit early, stop the web app being tested, and thus the tests then being unable to run because the web app had shut down.Pinning to
1.8.1fixes this.On the issue of failures not being reported correctly, the CLI seems to return a non-zero exit code even for a passing test suite, so in this command, the
--success firstflag prevents the build from exiting. However, it means a failing test suite for legitimate reasons does not fail the build.This will be looked into and queried with the team that author
browserstack-cypress-cli.