Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react v16.11 (#96) #99

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

tiagob
Copy link

@tiagob tiagob commented Aug 20, 2020

Description

Support react and react-dom 16.11.

References

#96

Testing

I tested by changing these lines
https://github.com/auth0/auth0-react/blob/master/package.json#L75-L76
to

    "react": "~16.11.0",
    "react-dom": "~16.11.0",

and running npm test (these all pass)

I reverted this because I figured it's better to test with 16.13 normally. Is there a different approach you'd like to take?

I tried setting up the integration tests but I ran into these kinds of errors:

Module not found: Can't resolve '@auth0/auth0-react' in ' ...
  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@tiagob tiagob requested a review from a team August 20, 2020 18:36
@adamjmcgrath
Copy link
Contributor

Thanks @tiagob

@tiagob
Copy link
Author

tiagob commented Aug 21, 2020

@adamjmcgrath how long does ci/circleci build take?

@lbalmaceda
Copy link
Contributor

@tiagob I imagine forked PRs are not set up to run on the CI. cc @adamjmcgrath

@tiagob
Copy link
Author

tiagob commented Oct 19, 2020

@adamjmcgrath I'm using this in a full stack developer tool I made. It generates the boilerplate for a full-stack. It includes Auth0 with RN/Expo and React web. I'd love to hear any advice or feedback you could provide

https://github.com/tiagob/create-full-stack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants