Memoize context value in auth0-provider #318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
We've seen a few instances where the context value in
Auth0Provider
needs to be memoized, as it is set to a new object value on each re-render and causes instances where we use the auth0 object inuseEffect
oruseCallback
to continuously re-evaluate.References
Similar to #150, but now we're memoizing the whole object.
Testing
Added a new test to
auth0-provider.test
and ran without my changes:then ran again with my changes:
Checklist
master