Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.7.0 #272

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Release v1.7.0 #272

merged 1 commit into from
Sep 6, 2021

Conversation

adamjmcgrath
Copy link
Contributor

Added

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner September 6, 2021 15:06
@adamjmcgrath adamjmcgrath added the review:tiny Tiny review label Sep 6, 2021
lbalmaceda
lbalmaceda reviewed Sep 6, 2021
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamjmcgrath given the changelog in the SPA JS library patch, shouldn't this be included as part of a PATCH release instead of a MINOR?

@adamjmcgrath
Copy link
Contributor Author

adamjmcgrath commented Sep 6, 2021 •
edited
Loading

This release is bumping SPA from 1.16.0 -> 1.17.1
There's another PR (#265 Run playground against Node OIDC Provider and BrowserStack) that bumped it from 1.16.0 -> 1.17.0 but i didn't include that in the changelog

@adamjmcgrath adamjmcgrath merged commit fe7fcb7 into master Sep 6, 2021
@adamjmcgrath adamjmcgrath deleted the release/v1.7.0 branch September 6, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjmcgrath @lbalmaceda