Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UserProfile.toMap and unit test #433

Closed
wants to merge 4 commits into from
Closed

Add UserProfile.toMap and unit test #433

wants to merge 4 commits into from

Conversation

MilesAdamson
Copy link

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

  • Added UserProfile.toMap() method
  • Added call to the above function in Credentials.toMap() to add the result in there

📎 References

#379

🎯 Testing

Unit test added which converts to/from map and checks the result

@MilesAdamson MilesAdamson requested a review from a team as a code owner April 9, 2024 19:57
@Widcket Widcket requested a review from a team as a code owner February 4, 2025 00:12
@Widcket
Copy link
Contributor

Widcket commented Feb 10, 2025

Hi @MilesAdamson, we'll close this PR in favor of #475. We appreciate your contribution nonetheless.

@Widcket Widcket closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasgolden-thimble lucasgolden-thimble lucasgolden-thimble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MilesAdamson @Widcket @lucasgolden-thimble