Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESD-34143: Prevent saving branding data in ul customize command if empty #968

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Feb 1, 2024

🔧 Changes

The changes in this PR prevent an error thrown when using the Auth0 CLI to customize the Universal Login, but not providing a page template.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught marked this pull request as ready for review February 1, 2024 13:16
@sergiught sergiught requested a review from a team as a code owner February 1, 2024 13:16
@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (5f72af6) 72.37% compared to head (ce70c5d) 72.32%.

Files Patch % Lines
internal/cli/universal_login_customize.go 0.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
- Coverage   72.37%   72.32%   -0.06%     
==========================================
  Files          93       93              
  Lines       12748    12755       +7     
==========================================
- Hits         9227     9225       -2     
- Misses       2974     2980       +6     
- Partials      547      550       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiught sergiught merged commit 9d0c9db into main Feb 1, 2024
8 checks passed
@sergiught sergiught deleted the ESD-34143 branch February 1, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants