Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv format to table views #955

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Add csv format to table views #955

merged 7 commits into from
Jan 4, 2024

Conversation

m3talsmith
Copy link
Contributor

@m3talsmith m3talsmith commented Jan 3, 2024

🔧 Changes

  • Adds csv as a general format cli wide for all table based views

📚 References

🔬 Testing

Manually verify that you get a csv back of your search results via auth0 users search --csv

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

Adds csv as a general format cli wide
Uses csv flag for user search
@m3talsmith m3talsmith requested a review from a team as a code owner January 3, 2024 19:10
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (12ca7e5) 72.23% compared to head (7cfd2ff) 72.35%.

Files Patch % Lines
internal/display/display.go 44.44% 7 Missing and 3 partials ⚠️
internal/cli/cli.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
+ Coverage   72.23%   72.35%   +0.12%     
==========================================
  Files          93       93              
  Lines       12656    12748      +92     
==========================================
+ Hits         9142     9224      +82     
- Misses       2969     2976       +7     
- Partials      545      548       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of adding a --csv flag; it was always something we considered during the v1.0.0 initiative. Though I usually like small PRs, I think we should apply this to all commands or at least test against all commands to make sure that the result writer works for all command ouputs.

internal/cli/cli.go Show resolved Hide resolved
internal/cli/users.go Show resolved Hide resolved
internal/display/display.go Show resolved Hide resolved
@m3talsmith m3talsmith changed the title Add csv format to user search results Add csv format to table views Jan 4, 2024
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid 👍

@m3talsmith m3talsmith merged commit 8ca147d into main Jan 4, 2024
8 checks passed
@m3talsmith m3talsmith deleted the DXCDT-607-export-users branch January 4, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add capability to export logs as type csv not just json.
4 participants