Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dxcdt 393 ensure status and progress indicator #949

Merged
merged 29 commits into from
Dec 21, 2023

Conversation

m3talsmith
Copy link
Contributor

🔧 Changes

In portions of the CLI (e.g. bulk delete), we can show progress details instead of just a spinner.

This PR creates the ProgressBar and uses it in those places.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

dependabot bot and others added 17 commits November 13, 2023 12:38
Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix: Remove or replace deprecations for GoReleaser config

Remove deprecated replacements
Replace deprecated brews tap
Replace deprecated scoop entries
Fix name_template to reflect exact current naming conventions

* DXCDT-582: Convert audience into a drop down in interactive mode in test token cmd (#906)

Convert audience into a drop down in interactive mode in test token cmd

* Bump github.com/auth0/go-auth0 from 1.2.0 to 1.3.0 (#908)

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…est token cmd (#906)

Convert audience into a drop down in interactive mode in test token cmd

Title Os for final release name fit
Create generic ProgressBar
Ensure 1 or less items behaves like Spinner
Add progress bars to possibly longer processes
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/auth0/go-auth0 from 1.2.0 to 1.3.0 (#908)

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* dxcdt-615-goreleaser-upgrade (#909)

* Fix: Remove or replace deprecations for GoReleaser config

Remove deprecated replacements
Replace deprecated brews tap
Replace deprecated scoop entries
Fix name_template to reflect exact current naming conventions

* DXCDT-582: Convert audience into a drop down in interactive mode in test token cmd (#906)

Convert audience into a drop down in interactive mode in test token cmd

* Bump github.com/auth0/go-auth0 from 1.2.0 to 1.3.0 (#908)

Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/auth0/go-auth0/releases)
- [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md)
- [Commits](auth0/go-auth0@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/auth0/go-auth0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* DXCDT-582: Convert audience into a drop down in interactive mode in test token cmd (#906)

Convert audience into a drop down in interactive mode in test token cmd

Title Os for final release name fit

* Bump goreleaser version

* Increase default page amount to 100 results per page

* Updated docs for defalut list limit

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@m3talsmith m3talsmith requested a review from a team as a code owner December 20, 2023 16:37
This is a specific error, internal to the developer and not of use to the user
internal/ansi/progress.go Outdated Show resolved Hide resolved
internal/ansi/progress.go Show resolved Hide resolved
internal/cli/actions.go Outdated Show resolved Hide resolved
internal/cli/apis.go Outdated Show resolved Hide resolved
internal/cli/apis.go Outdated Show resolved Hide resolved
internal/cli/data/universal-login/assets/index-89540052.js Outdated Show resolved Hide resolved
Michael Christenson II and others added 4 commits December 21, 2023 13:09
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (859f796) 72.33% compared to head (070b652) 72.31%.

❗ Current head 070b652 differs from pull request most recent head 463832a. Consider uploading reports for the commit 463832a to get more accurate results

Files Patch % Lines
internal/ansi/progress.go 57.89% 8 Missing ⚠️
internal/cli/users_blocks.go 53.84% 4 Missing and 2 partials ⚠️
internal/cli/apis.go 28.57% 3 Missing and 2 partials ⚠️
internal/cli/apps.go 37.50% 3 Missing and 2 partials ⚠️
internal/cli/custom_domains.go 37.50% 3 Missing and 2 partials ⚠️
internal/cli/log_streams.go 37.50% 3 Missing and 2 partials ⚠️
internal/cli/roles.go 37.50% 3 Missing and 2 partials ⚠️
internal/cli/rules.go 37.50% 3 Missing and 2 partials ⚠️
internal/cli/users.go 37.50% 3 Missing and 2 partials ⚠️
internal/cli/organizations.go 71.42% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
- Coverage   72.33%   72.31%   -0.03%     
==========================================
  Files          92       93       +1     
  Lines       12660    12656       -4     
==========================================
- Hits         9158     9152       -6     
- Misses       2959     2963       +4     
+ Partials      543      541       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Michael Christenson II added 3 commits December 21, 2023 13:29
@m3talsmith m3talsmith enabled auto-merge (squash) December 21, 2023 19:05
@m3talsmith m3talsmith merged commit 5620e50 into main Dec 21, 2023
8 checks passed
@m3talsmith m3talsmith deleted the DXCDT-393-ensure-status-and-progress-indicator branch December 21, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants