Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-587: Warn if deleting client used to authenticate #934

Merged

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Dec 4, 2023

🔧 Changes

This PR adds a warning message communicating to the user that they're about to delete the client used to authenticate the CLI. This doesn't have immediate ramifications for the CLI but will prevent the CLI from being able to re-authenticate once the access token eventually expires.

We had considered preventing the user from deleting the application altogether, but there are some valid use-cases for this behavior.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner December 4, 2023 20:40
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ed632b4) 72.31% compared to head (4db5057) 72.29%.

Files Patch % Lines
internal/cli/apps.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   72.31%   72.29%   -0.02%     
==========================================
  Files          92       92              
  Lines       12500    12503       +3     
==========================================
  Hits         9039     9039              
- Misses       2930     2933       +3     
  Partials      531      531              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willvedd willvedd merged commit 3ea19cd into main Dec 5, 2023
8 checks passed
@willvedd willvedd deleted the DXCDT-587-prevent-deletion-of-current-client-and-grant branch December 5, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants