Prevent access token writen to config file if stored in keyring #919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR corrects a fairly innocuous, yet faulty error check when storing access token to the keyring. We want to write the access token to the config file as a backup if we're unable to successfully write to the keyring. As it exists now, the token will be written to the config file only if the keyring storage succeeds.
🔬 Testing
Manual verification; unable to adequately test the token regeneration function at this time.
📝 Checklist