Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent access token writen to config file if stored in keyring #919

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Nov 21, 2023

🔧 Changes

This PR corrects a fairly innocuous, yet faulty error check when storing access token to the keyring. We want to write the access token to the config file as a backup if we're unable to successfully write to the keyring. As it exists now, the token will be written to the config file only if the keyring storage succeeds.

🔬 Testing

Manual verification; unable to adequately test the token regeneration function at this time.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner November 21, 2023 23:42
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (63ccef0) 72.45% compared to head (4c4f591) 72.42%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/config/tenant.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
- Coverage   72.45%   72.42%   -0.03%     
==========================================
  Files          93       92       -1     
  Lines       12472    12462      -10     
==========================================
- Hits         9036     9026      -10     
  Misses       2910     2910              
  Partials      526      526              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willvedd willvedd merged commit ea60669 into main Nov 22, 2023
8 checks passed
@willvedd willvedd deleted the fix-dont-expose-acces-token-config branch November 22, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants