DXCDT-589: Enable description prompt in interactive mode when updating roles #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
==========================================
- Coverage 72.41% 72.41% -0.01%
==========================================
Files 93 93
Lines 12440 12447 +7
==========================================
+ Hits 9008 9013 +5
- Misses 2907 2908 +1
- Partials 525 526 +1 ☔ View full report in Codecov by Sentry. |
Widcket
approved these changes
Nov 17, 2023
willvedd
reviewed
Nov 17, 2023
| if inputs.Description != "" { | ||
| r.Description = &inputs.Description | ||
| updatedRole.Description = &inputs.Description | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it possible to provide no name and no description on update? If so, might we detect that and prevent an API request that will inevitably fail?
There was a problem hiding this comment.
The API doesn't fail if we do not provide any name or description, it will simply behave as a GET.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
In this PR we enable the description prompt in interactive mode when updating roles. Furthermore we enhance the default text for the name and description prompts with information from the current role.
📚 References
🔬 Testing
📝 Checklist