DXCDT-555: Include universal-login customize assets #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
DXCDT-555-bake-assets
branch
from
8dc0777
to
a8996e4
Compare
willvedd
reviewed
Oct 30, 2023
willvedd
reviewed
Oct 30, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/auth0-universal-login-customize #891 +/- ##
==========================================================================
Coverage ? 72.43%
==========================================================================
Files ? 93
Lines ? 12334
Branches ? 0
==========================================================================
Hits ? 8934
Misses ? 2882
Partials ? 518 ☔ View full report in Codecov by Sentry. |
willvedd
approved these changes
Oct 30, 2023
Widcket
reviewed
Oct 30, 2023
|
|
||
| assets: ## Generate Universal Login embeddable assets | ||
| ${call print, "Generating Universal Login embeddable assets"} | ||
| @if [ ! -d "${UNIVERSAL_LOGIN_ASSETS_EXTERNAL_DIR}" ]; \ |
There was a problem hiding this comment.
Maybe use mkdir -p to create the directory if it doesn't exist already?
There was a problem hiding this comment.
Creating the directory is not enough, we need to actually clone the web app repo as well, which is not public, hence why we only check for the existence.
Widcket
approved these changes
Oct 31, 2023
sergiught
merged commit 6cdf650
into
feature/auth0-universal-login-customize
8 checks passed
sergiught
added a commit
that referenced
this pull request
Nov 1, 2023
* Add make command to generate universal-login preview assets * Add universal-login preview assets * Add route to serve universal-login customize assets * Update assets * Minor tweaks to web server url path * Update assets * Add npm install to make assets * Remove ws_port query param * Update assets * Tiny improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR includes the
auth0 universal-login customizeassets.📚 References
🔬 Testing
📝 Checklist