Use stable version of text locales url #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
commented
Oct 16, 2023
| @@ -242,10 +241,6 @@ func mergeBrandingTextTranslations( | |||
| } | |||
|
|
|||
| for key, text := range translations { | |||
| if strings.HasPrefix(key, "error") || strings.HasPrefix(key, "devKeys") || key == "usernameOnlyPlaceholder" { | |||
There was a problem hiding this comment.
I went through the entire list of default translations and there aren't really any that start with devKeys, but there are valid ones that start with error that should be within the returned result.
There was a problem hiding this comment.
Good work, things have changed a bit since this feature was first developed.
Widcket
approved these changes
Oct 16, 2023
sergiught
merged commit 0b7a7c4
into
feature/auth0-universal-login-customize
8 checks passed
sergiught
added a commit
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Use stable version of text locales url instead of development.
📚 References
🔬 Testing
📝 Checklist