Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF Generate - enforce that CLI and TF provider domains match #858

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Sep 26, 2023

🔧 Changes

One piece of feedback received on auto-generating TF configuration is that it isn't well defined that the Auth0 domains for the TF provider and Auth0 CLI need to match. This relationship was supposed to be implied but is now enforced through this PR. If the two domains do not match, an error will be thrown and the entire process will fail early, otherwise the process will inevitably fail at a later point.

Another similar PR was introduced in the TF provider to emphasize this requirement in the docs.

📚 References

🔬 Testing

Added unit tests for new function. Added integration test case.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner September 26, 2023 12:55
@willvedd willvedd changed the title Adding checks if domains match, tests TF Generate - enforce that CLI and TF provider domains match Sep 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0e0c0a2) 73.35% compared to head (199f6eb) 73.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   73.35%   73.40%   +0.04%     
==========================================
  Files          92       92              
  Lines       11883    11893      +10     
==========================================
+ Hits         8717     8730      +13     
+ Misses       2649     2647       -2     
+ Partials      517      516       -1     
Files Coverage Δ
internal/cli/terraform.go 87.57% <100.00%> (+0.39%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willvedd willvedd merged commit c9c09f2 into main Sep 26, 2023
8 checks passed
@willvedd willvedd deleted the ESD-31286-tf-generate-check-credentials-match branch September 26, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants