Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Heap integration [CLI-158] #302

Merged
merged 5 commits into from
May 24, 2021
Merged

Add Heap integration [CLI-158] #302

merged 5 commits into from
May 24, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented May 23, 2021

Description

This PR integrates Heap to track the following events (only on production builds):

  • The first login
  • Every command executed that requires login

Screen Shot 2021-05-23 at 18 29 54

Screen Shot 2021-05-23 at 18 28 42

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team May 23, 2021 23:25

event := newEvent(eventName, id)

t.wg.Add(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a commentary that we can't technically do wg.Add after we do wg.Wait -- that would cause a panic. As long as we're synchronously done doing all the wg.Adds before we Wait, it's fine.

There's other async style ways we can do this as well (e.g. utilizing a single channel, a single worker) to future proof against this potential issue.

Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, just a minor potential issue with wg.Add / wg.Wait races, but 👍

@Widcket Widcket merged commit c5ff007 into main May 24, 2021
@Widcket Widcket deleted the heap-tracks branch May 24, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants