Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Custom Domains Data Display and Delete Method for All Commands #1083

Merged
merged 10 commits into from
Oct 4, 2024

Conversation

developerkunal
Copy link
Contributor

🔧 Changes

  • Fixed the issue where custom domain configuration details were not displayed to users.
  • Resolved the delete method issue for all commands that were not functioning correctly.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@developerkunal developerkunal requested a review from a team as a code owner October 3, 2024 06:06
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.11%. Comparing base (5df5c93) to head (29ea2d5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/display/custom_domain.go 93.47% 2 Missing and 1 partial ⚠️
internal/cli/input.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
+ Coverage   72.05%   72.11%   +0.05%     
==========================================
  Files          94       94              
  Lines       12942    12978      +36     
==========================================
+ Hits         9326     9359      +33     
- Misses       3069     3071       +2     
- Partials      547      548       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

duedares-rvj
duedares-rvj previously approved these changes Oct 4, 2024
duedares-rvj
duedares-rvj previously approved these changes Oct 4, 2024
@developerkunal developerkunal enabled auto-merge (squash) October 4, 2024 05:50
@developerkunal developerkunal merged commit 50c25da into main Oct 4, 2024
11 checks passed
@developerkunal developerkunal deleted the fix-custom-domain-details-and-delete-list-issue branch October 4, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants