-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXCDT-583: Convert scopes into a drop down in interactive mode in test token cmd #907
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
==========================================
- Coverage 72.90% 72.48% -0.42%
==========================================
Files 93 93
Lines 12337 12412 +75
==========================================
+ Hits 8994 8997 +3
- Misses 2822 2893 +71
- Partials 521 522 +1
☔ View full report in Codecov by Sentry. |
Should we print a warning when the app is M2M and scopes were passed? |
Maybe? It may be worth educating users of that misuse but there will be no ill consequences if they do include them. |
Should it be an "info" instead of a "warning" then? |
As a user, if a pass a combination of inputs expecting a certain result, I expect the app to let me know if this result cannot be achieved. |
It is a form of invalid input, after all. I wonder if there should be a flag validation rule for this, instead of a printed 'info'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled and confirm that this works as intended.
🔧 Changes
This PR converts the scopes flag into a multi selector picker when in interactive mode for the
auth0 test token
command.📚 References
🔬 Testing
📝 Checklist